-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mgmt_type into device metadata YANG model. #21897
Conversation
645b39e
to
9cdff9e
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -157,6 +157,11 @@ module sonic-device_metadata { | |||
type string; | |||
} | |||
|
|||
leaf mgmt_type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this field be enum, or it is arbitrary value? Also, is there any restrcition? like length bound, lastly, is it mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is just a user-specified string, no pattern, not enum. the way to use it is in the template evaluation.
this field is optional, not mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Commenter does not have sufficient privileges for PR 21897 in repo sonic-net/sonic-buildimage |
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 21897 in repo sonic-net/sonic-buildimage |
a0fd70d
to
c137d09
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick PR to 202411: #21934 |
Add mgmt_type into device metadata YANG model.
Add mgmt_type into device metadata YANG model.
Cherry-pick PR to 202405: #21944 |
Why I did it
Enhance yang model for networking-metadata.
Adding a new field in device metadata YANG model to distinguish the management type of the device. Depends on the users, this field can be used to tell the purpose of deployment or who/how the device is being managed.
Work item tracking
How I did it
This change adds a new field called mgmt_type for this purpose.
How to verify it
Unit test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)