Add mgmt_type into device metadata YANG model. #21897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
force-pushed
the
user/r12f/update-yang
branch
from
645b39e to
9cdff9e
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Mar 1, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ganglyu
reviewed
Mar 2, 2025
| @@ -157,6 +157,11 @@ module sonic-device_metadata { | |||
| type string; | |||
| } | |||
|
|
|||
| leaf mgmt_type { | |||
There was a problem hiding this comment.
Would this field be enum, or it is arbitrary value? Also, is there any restrcition? like length bound, lastly, is it mandatory?
There was a problem hiding this comment.
it is just a user-specified string, no pattern, not enum. the way to use it is in the template evaluation.
this field is optional, not mandatory.
qiluo-msft
approved these changes
Mar 3, 2025
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21897 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 21897 in repo sonic-net/sonic-buildimage |
r12f
force-pushed
the
user/r12f/update-yang
branch
from
a0fd70d to
c137d09
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
13 tasks
|
Cherry-pick PR to 202411: #21934 |
miatttao
pushed a commit
to miatttao/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Add mgmt_type into device metadata YANG model.
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Add mgmt_type into device metadata YANG model.
13 tasks
|
Cherry-pick PR to 202405: #21944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Enhance yang model for networking-metadata.
Adding a new field in device metadata YANG model to distinguish the management type of the device. Depends on the users, this field can be used to tell the purpose of deployment or who/how the device is being managed.
Work item tracking
How I did it
This change adds a new field called mgmt_type for this purpose.
How to verify it
Unit test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)