Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia][Device] Add BCM DNX soc properties to set STAN_ALN mode correctly #21864

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saksarav-nokia
Copy link
Contributor

Why I did it

The STAN_ALN mode was set incorrectly in BCM DNX asics and was advised by BCM to set these soc variables to correct it (One FAP with STAN_ALN=1 and other FAPs with STAN_ALN=0).

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added the soc variables in BCM config

How to verify it

Verified the STAN_ALN mode and also passing traffic without any issues.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@saksarav-nokia
Copy link
Contributor Author

@vmittal-msft @arlakshm @rlhui , Please review it

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui requested a review from vmittal-msft February 27, 2025 15:37
@rlhui rlhui added the P0 Priority of the issue label Feb 27, 2025
Copy link
Contributor

@vmittal-msft vmittal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saksarav-nokia we may need to change high/low to 50%/25% of total fabric links as per BRCM recommendation. please update/re-test.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft
Copy link
Contributor

@rlhui @yxieca please help merge.

@kperumalbfn
Copy link
Contributor

@vmittal-msft do we need this in 202411, could you pls check it.

…ctly

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft
Copy link
Contributor

vmittal-msft commented Mar 14, 2025

@vmittal-msft do we need this in 202411, could you pls check it.

No. Let me remove tag.

@vmittal-msft
Copy link
Contributor

@vmittal-msft do we need this in 202411, could you pls check it.

Yes

@kperumalbfn
Copy link
Contributor

kperumalbfn commented Mar 14, 2025

Thanks @vmittal-msft

@saksarav-nokia Please create a separate PR for 202411 after merge as we have conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants