libyang: upgrade to v3 step 4 -- update all libyang1 users to also use libyang3 #21718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
f15060e to
ab8c1bb
Compare
bradh352
changed the title
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
ab8c1bb to
eb5556c
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
eb5556c to
5b60bd7
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
changed the title
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
5b60bd7 to
d89e511
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
8655d17 to
7786b7f
Compare
|
/azp run Azure.sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 2, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 2, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 2, 2025
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
0097acd to
fd0d0f0
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 3, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 3, 2025
libyang1 and libyang3 can coexist (except for the dev packages). Even if a package doesn't directly depend on libyang, full dependency tracking isn't smart enough to pull in deps of an actual specified dependency, so we need to tag all users of libyang as also a user of libyang3 (including python bindings if they were previously specified). In a future commit we will remove all libyang1 references.
bradh352
force-pushed
the
bradh352/libyang3-pr3
branch
from
fd0d0f0 to
0b19bc4
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Even if a package doesn't directly depend on libyang, full dependency tracking isn't smart enough to pull in deps of an
actual specified dependency, so we need to tag all users of libyang as also a user of libyang3 (including python bindings
if they were previously specified).
In a future commit we will remove all libyang1 references.
NOTE: this PR actually includes (as a squashed commits) PR #21679, #21719, #21716. Please review the individual commits (skipping the squashed commit) otherwise this may seem too large/confusing.
Depends on #21679, #21719, #21716
Tracking PR #21679
Work item tracking
How I did it
How to verify it
See build and tests succeed here.
Which release branch to backport (provide reason below if selected)
N/A
Tested branch (Please provide the tested image version)
master as of 20250212
Description for the changelog
sonic-config-engine: no need to depend on libyang3
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Brad House (@bradh352)