Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyang: upgrade to v3 step 4 -- update all libyang1 users to also use libyang3 #21718

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bradh352
Copy link
Contributor

@bradh352 bradh352 commented Feb 12, 2025

Why I did it

Even if a package doesn't directly depend on libyang, full dependency tracking isn't smart enough to pull in deps of an
actual specified dependency, so we need to tag all users of libyang as also a user of libyang3 (including python bindings
if they were previously specified).

In a future commit we will remove all libyang1 references.

NOTE: this PR actually includes (as a squashed commits) PR #21679, #21719, #21716. Please review the individual commits (skipping the squashed commit) otherwise this may seem too large/confusing.

Depends on #21679, #21719, #21716

Tracking PR #21679

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

See build and tests succeed here.

Which release branch to backport (provide reason below if selected)

N/A

Tested branch (Please provide the tested image version)

master as of 20250212

Description for the changelog

sonic-config-engine: no need to depend on libyang3

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Brad House (@bradh352)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 changed the title sonic-config-engine: no need to depend on libyang3 sonic-config-engine: no need to depend on libyang Feb 12, 2025
@bradh352 bradh352 marked this pull request as draft February 12, 2025 16:50
@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from f15060e to ab8c1bb Compare February 12, 2025 18:20
@bradh352 bradh352 changed the title sonic-config-engine: no need to depend on libyang sonic-config-engine: update dependencies for libyang3 Feb 12, 2025
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from ab8c1bb to eb5556c Compare February 12, 2025 18:41
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from eb5556c to 5b60bd7 Compare February 12, 2025 18:41
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 changed the title sonic-config-engine: update dependencies for libyang3 libyang: upgrade to v3 step 4 - port sonic-config-engine Feb 12, 2025
@bradh352 bradh352 changed the title libyang: upgrade to v3 step 4 - port sonic-config-engine libyang: upgrade to v3 step 4 -- port sonic-config-engine Feb 12, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Feb 12, 2025
@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from 5b60bd7 to d89e511 Compare February 12, 2025 22:50
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 changed the title libyang: upgrade to v3 step 4 -- port sonic-config-engine libyang: upgrade to v3 step 4 -- update all libyang1 users to also use libyang3 Feb 12, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Feb 12, 2025
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from 8655d17 to 7786b7f Compare February 13, 2025 12:08
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 1, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 2, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 2, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 2, 2025
@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from 0097acd to fd0d0f0 Compare March 3, 2025 15:02
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 3, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 3, 2025
bradh352 added 5 commits March 5, 2025 20:10
libyang1 and libyang3 can coexist (except for the dev packages).

Even if a package doesn't directly depend on libyang, full
dependency tracking isn't smart enough to pull in deps of an
actual specified dependency, so we need to tag all users of
libyang as also a user of libyang3 (including python bindings
if they were previously specified).

In a future commit we will remove all libyang1 references.
@bradh352 bradh352 force-pushed the bradh352/libyang3-pr3 branch from fd0d0f0 to 0b19bc4 Compare March 6, 2025 10:25
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 6, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 6, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 6, 2025
bradh352 added a commit to bradh352/sonic-buildimage that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants