Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7060dx5_32: Add new 25Gx64-100Gx8-400Gx8-400Gx4 HwSku #21673

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bobbymcgonigle
Copy link
Contributor

Why I did it

Customer requested this port configuration

Work item tracking
  • Microsoft ADO (number only):

How I did it

Creating a new hwsku to reflect the required port configuration, and adding a media_settings.json to reflect the serdes rate + medium type

How to verify it

Load on the device and use sonic-cfggen to generate a config_db.json.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

202411

Description for the changelog

7060dx5_32: Add new 25Gx64-100Gx8-400Gx8-400Gx4 HwSku

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -0,0 +1,86 @@
#name lanes alias index speed fec subport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hwsku directory went into the wrong folder. should be x86_64-arista_7060dx5_32 for 7060DX5_32 platform instead of x86_64-arista_7050dx4_32s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephen, I Fixed this issue on the Draft and opened it ready for review. I have tested this locally and was able to get all links up. Please let me know if there's an issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbymcgonigle When you say "was able to get all links up", did you mean all 25G DAC, 100G DAC, 400G DAC and 400G Optic ports? Can you paste the "show interface status" output in this PR?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

1 similar comment
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bobbymcgonigle bobbymcgonigle marked this pull request as ready for review February 12, 2025 20:46
@@ -0,0 +1,86 @@
#name lanes alias index speed fec subport
Ethernet0 1 Ethernet1/1 1 25000 none 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have fec = fc for 25G ports.

@@ -0,0 +1,86 @@
#name lanes alias index speed fec subport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbymcgonigle When you say "was able to get all links up", did you mean all 25G DAC, 100G DAC, 400G DAC and 400G Optic ports? Can you paste the "show interface status" output in this PR?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Ethernet232 489,490,491,492,493,494,495,496 Ethernet30/1 30 400000 rs 0
Ethernet240 497,498,499,500,501,502,503,504 Ethernet31/1 31 400000 rs 0
Ethernet248 505,506,507,508,509,510,511,512 Ethernet32/1 32 400000 rs 0
Ethernet256 513 Ethernet33 33 10000 fc 0
Copy link
Collaborator

@zhenggen-xu zhenggen-xu Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should use fc FEC for 10G. Use none instead

NUM_LANES: 1
?
PORT_ID: [[1, 32],
[34, 50],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but why port 50 is here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants