Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia-7220 IXR] Update NOKIA 7220 H4, H4-32D, H5-64D platforms #21357

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

fzhou-nokia
Copy link
Contributor

Why I did it

Update for NOKIA 7220 H4-32D and NOKIA 7220 H4 to support breakout mode
Update for NOKIA 7220 H5-64D to achieve 100% pass in OC for T1 topology

Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. Added files under ../device/nokia/x86_64-nokia_ixr7220_h4_32d-r0 directory.
  2. Added files under ../device/nokia/x86_64-nokia_ixr7220_h4-r0 directory.
  3. Added files under ../device/nokia/x86_64-nokia_ixr7220_h5_64d-r0 directory.

How to verify it

  1. Make sure the sonic-buildimage is successful
  2. Run this image on x86_64-nokia_ixr7220_h4_32d-r0, x86_64-nokia_ixr7220_h4-r0 and x86_64-nokia_ixr7220_h5_64d-r0, verify all dockers are up and test basic commands like:
  • show version
  • show platform summary
  • show platform syseeprom
  • show platform fan
  • show platform psustatus
  • show platform firmware status
  • show platform temperature
  • sudo show system-health detail
  • show interface status
  1. Run OC test, for T0/T1 topology and have 100% pass on all 3 platforms.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405
  • 202411

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@fzhou-nokia
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fzhou-nokia sonic follows alias name as etpXX. can we follow that convention?
Ref:- https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prgeor can you please give us a pass on these older platforms as this in only a bug fix PR and I will make sure that all our newer platforms follow the suggested naming convention

We observed that most of the platforms already in SONiC by other Vendors are using the same naming convention we have here for port naming and breakouts that is the reason we went with this naming convention assuming that the document attached here is outdated as it was more than 7 years old

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i am aware of not following. ideally we should have a build check to fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have implemented all the face plate and Fru LED's based on ledd using "led_control.py"as per the porting guide. From the SONiC porting guide the port LED's are controlled by "led_proc_init.soc" which inturn uses this Custom_led.bin. The Custom_led.bin file was provided to us by the ASIC vendor, this is consumed by the Broadcom SDK to control the port LED's

Copy link
Contributor

@prgeor prgeor Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fzhou-nokia which porting guide are you following. please share the link. is the porting guide asking to use custom binary

@Pavan-Nokia
Copy link
Contributor

Hi @prgeor
Please help Merge this PR

@yxieca yxieca merged commit 7f1f300 into sonic-net:master Feb 27, 2025
20 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21937

miatttao pushed a commit to miatttao/sonic-buildimage that referenced this pull request Mar 5, 2025
…c-net#21357)

Why I did it
Update for NOKIA 7220 H4-32D and NOKIA 7220 H4 to support breakout mode
Update for NOKIA 7220 H5-64D to achieve 100% pass in OC for T1 topology

How I did it
Added files under ../device/nokia/x86_64-nokia_ixr7220_h4_32d-r0 directory.
Added files under ../device/nokia/x86_64-nokia_ixr7220_h4-r0 directory.
Added files under ../device/nokia/x86_64-nokia_ixr7220_h5_64d-r0 directory.

How to verify it
Make sure the sonic-buildimage is successful
Run this image on x86_64-nokia_ixr7220_h4_32d-r0, x86_64-nokia_ixr7220_h4-r0 and x86_64-nokia_ixr7220_h5_64d-r0, verify all dockers are up and test basic commands like:
show version
show platform summary
show platform syseeprom
show platform fan
show platform psustatus
show platform firmware status
show platform temperature
sudo show system-health detail
show interface status
Run OC test, for T0/T1 topology and have 100% pass on all 3 platforms.
prabhataravind pushed a commit to prabhataravind/sonic-buildimage that referenced this pull request Mar 5, 2025
…c-net#21357)

Why I did it
Update for NOKIA 7220 H4-32D and NOKIA 7220 H4 to support breakout mode
Update for NOKIA 7220 H5-64D to achieve 100% pass in OC for T1 topology

How I did it
Added files under ../device/nokia/x86_64-nokia_ixr7220_h4_32d-r0 directory.
Added files under ../device/nokia/x86_64-nokia_ixr7220_h4-r0 directory.
Added files under ../device/nokia/x86_64-nokia_ixr7220_h5_64d-r0 directory.

How to verify it
Make sure the sonic-buildimage is successful
Run this image on x86_64-nokia_ixr7220_h4_32d-r0, x86_64-nokia_ixr7220_h4-r0 and x86_64-nokia_ixr7220_h5_64d-r0, verify all dockers are up and test basic commands like:
show version
show platform summary
show platform syseeprom
show platform fan
show platform psustatus
show platform firmware status
show platform temperature
sudo show system-health detail
show interface status
Run OC test, for T0/T1 topology and have 100% pass on all 3 platforms.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants