Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snappi-Ixload package for docker-sonic-mgmt #20808

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

albertovillarreal-keys
Copy link
Contributor

Adding additional python packages needed for IxLoad Snappi for DASH smartswitch testcases.

Why I did it

Test cases for DASH smartswitch will require added python packages

Work item tracking
  • Microsoft ADO (number only):

How I did it

Built a Docker image for sonic-mgmt on my local setup.

How to verify it

Ran an Ixload and IxNetwork snappi test to validate.

Which release branch to backport (provide reason below if selected)

None

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202405

Description for the changelog

Added python packages ipaddress, macaddress, and snappi_ixload.

Link to config_db schema for YANG module changes

na

A picture of a cute animal (not mandatory but encouraged)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Adding additional python packages needed for IxLoad Snappi for DASH smartswitch testcases.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
removing flask module
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@albertovillarreal-keys albertovillarreal-keys marked this pull request as ready for review January 22, 2025 13:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@albertovillarreal-keys albertovillarreal-keys changed the title Snappi-Ixload Snappi-Ixload for docker-sonic-mgmt Jan 22, 2025
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the PR title to be more descriptive. The change looks good to me.

@r12f r12f requested a review from yxieca January 22, 2025 21:13
@albertovillarreal-keys albertovillarreal-keys changed the title Snappi-Ixload for docker-sonic-mgmt Add Snappi-Ixload package for docker-sonic-mgmt Jan 29, 2025
ipython==5.4.1 \
ixload \
ixnetwork-restpy==1.0.64 \
ixnetwork-open-traffic-generator==0.0.79 \
jinja2==2.10.1 \
snappi[ixnetwork,convergence]==0.5.11 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's already a version for this on L195, pls remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make sure there are no duplicate packages

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@developfast
Copy link
Contributor

pls ensure tests pass before merging

jsonpatch \
lazy-object-proxy==1.6.0 \
lxml \
macaddress \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertovillarreal-keys any other package required for vxlan/ipinip/nvgre tunnel traffic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn not at this time other packages required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albertovillarreal-keys will merge

@kperumalbfn kperumalbfn merged commit fa72373 into sonic-net:master Mar 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants