Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gNOI Warm Reboot - Added tests #20801

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

gNOI Warm Reboot - Added tests #20801

wants to merge 8 commits into from

Conversation

rkavitha-hcl
Copy link
Contributor

@rkavitha-hcl rkavitha-hcl commented Nov 14, 2024 •
edited
Loading

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Added test cases for warm reboot.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from b5f6845 to 9dd208a Compare November 15, 2024 12:49
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 3 times, most recently from 165ac73 to 2bfdab7 Compare November 26, 2024 11:22
kishanps
kishanps reviewed Nov 27, 2024
View reviewed changes
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 6 times, most recently from 4194e72 to c3b6888 Compare December 4, 2024 07:39
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from c11590c to ad96646 Compare December 5, 2024 10:44
@kishanps
Copy link

kishanps commented Dec 6, 2024

@github76543 Joh, can you PTAL and signoff.

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 3 times, most recently from 26e2ea9 to 4b6bfbb Compare December 12, 2024 07:04
@rkavitha-hcl rkavitha-hcl mentioned this pull request Dec 13, 2024
Merged
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from 0918d69 to b7f84ed Compare January 27, 2025 10:37
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@rkavitha-hcl
Copy link
Contributor Author

Test results:

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63060 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68474 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_asan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63103 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68527 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_tsan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63119 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68746 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_usan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63062 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68473 ms total)
[  PASSED  ] 41 tests.

@hdwhdw hdwhdw mentioned this pull request Jan 31, 2025
Draft
11 tasks
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft requested a review from wen587 February 18, 2025 21:26
@qiluo-msft qiluo-msft requested a review from hdwhdw February 18, 2025 23:32
qiluo-msft
qiluo-msft reviewed Feb 18, 2025
View reviewed changes
rules/framework.mk
@@ -0,0 +1,19 @@
# framework package

FRAMEWORK = framework_1.0.0_$(CONFIGURED_ARCH).deb
Copy link
Collaborator

@qiluo-msft qiluo-msft Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework

framework is a confusing name, according to HLD, you want to name it as 'WarmbootManager' ? #Pending

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared the alternative names in the other thread, can we go with sysmgr ?

qiluo-msft
qiluo-msft reviewed Feb 18, 2025
View reviewed changes
src/sonic-framework/tests/Makefile.am
test_main.cpp

tests_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_COVERAGE) $(CFLAGS_SAI)
tests_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_COVERAGE) $(CFLAGS_SAI)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COVERAGE

Could you share the coverage data? even better, you can refine build pipeline to expose the coverage data.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our internal tools show 90% coverage, we will look at refining the build pipeline to expose this as a followup item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdwhdw hdwhdw hdwhdw left review comments

@qiluo-msft qiluo-msft qiluo-msft left review comments

@kishanps kishanps kishanps left review comments

@bibhuprasad-hcl bibhuprasad-hcl bibhuprasad-hcl left review comments

@xumia xumia Awaiting requested review from xumia xumia is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@wen587 wen587 Awaiting requested review from wen587

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkavitha-hcl @kishanps @mssonicbld @hdwhdw @qiluo-msft @bibhuprasad-hcl