Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gNOI Cold Reboot - Integrated tests #20711

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gNOI Cold Reboot - Integrated tests #20711

wants to merge 3 commits into from

Conversation

rkavitha-hcl
Copy link
Contributor

@rkavitha-hcl rkavitha-hcl commented Nov 6, 2024 •
edited
Loading

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Added UT cases for Cold Reboot feature.
Added component tests for warm reboot.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@rkavitha-hcl rkavitha-hcl requested a review from lguohan as a code owner November 6, 2024 07:36
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR3 branch 3 times, most recently from d4ba3f9 to ad91226 Compare November 18, 2024 09:46
@kishanps
Copy link

@hdwhdw @vvolam @qiluo-msft Pls review

hdwhdw
hdwhdw suggested changes Nov 25, 2024
View reviewed changes
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR3 branch 4 times, most recently from 8c4cb6c to efa4a2b Compare December 3, 2024 08:13
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR3 branch 5 times, most recently from 663ac61 to 8d52b9b Compare December 4, 2024 14:30
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bibhuprasad-hcl
Copy link

@kishanps , could you pls review

1 similar comment
@bibhuprasad-hcl
Copy link

@kishanps , could you pls review

@bibhuprasad-hcl
Copy link

@vvolam , could you please review.

@bibhuprasad-hcl
Copy link

@hdwhdw , could you please review

hdwhdw
hdwhdw suggested changes Feb 20, 2025
View reviewed changes
Copy link

@hdwhdw hdwhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An honest question: has this changes be continuously run internally in Google? There are many hard timeout here in the test and I am curious whether they are generous enough to allow different performance in different environments, so we don't flake.

@hdwhdw hdwhdw self-requested a review February 25, 2025 22:08
hdwhdw
hdwhdw approved these changes Feb 25, 2025
View reviewed changes
Copy link

@hdwhdw hdwhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave styling to future work.

@hdwhdw hdwhdw mentioned this pull request Feb 26, 2025
Open
11 tasks
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Mar 11, 2025

@rkavitha-hcl could you please point me to the change in the code where we are waiting for HALT method, only for pmon container to be killed?

Also, could you modify the code such a way that if container is killed before timeout, can we return success?

Please don't force push the changes. Thank you!

@kishanps
Copy link

@rkavitha-hcl could you please point me to the change in the code where we are waiting for HALT method, only for pmon container to be killed?

Also, could you modify the code such a way that if container is killed before timeout, can we return success?

The pmon container wait is in the sonic-host-services
cc: @rkavitha-hcl @jaanah-hcl

@vvolam
Copy link
Contributor

vvolam commented Mar 11, 2025

@rkavitha-hcl could you please point me to the change in the code where we are waiting for HALT method, only for pmon container to be killed?
Also, could you modify the code such a way that if container is killed before timeout, can we return success?

The pmon container wait is in the sonic-host-services cc: @rkavitha-hcl @jaanah-hcl

Thank you @kishanps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bibhuprasad-hcl bibhuprasad-hcl bibhuprasad-hcl left review comments

@hdwhdw hdwhdw hdwhdw approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@vvolam vvolam Awaiting requested review from vvolam

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkavitha-hcl @kishanps @mssonicbld @bibhuprasad-hcl @vvolam @hdwhdw