-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gNOI Cold Reboot - Integrated tests #20711
base: master
Are you sure you want to change the base?
Conversation
d4ba3f9
to
ad91226
Compare
@hdwhdw @vvolam @qiluo-msft Pls review |
ad91226
to
ee29b8b
Compare
8c4cb6c
to
efa4a2b
Compare
663ac61
to
8d52b9b
Compare
8d52b9b
to
446d015
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
446d015
to
00176e7
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
00176e7
to
2253140
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
2253140
to
e9bfc38
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@kishanps , could you pls review |
1 similar comment
@kishanps , could you pls review |
@vvolam , could you please review. |
@hdwhdw , could you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An honest question: has this changes be continuously run internally in Google? There are many hard timeout here in the test and I am curious whether they are generous enough to allow different performance in different environments, so we don't flake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave styling to future work.
a70389c
to
56f2919
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
56f2919
to
894cc17
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
894cc17
to
6af51ad
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
6af51ad
to
80c2e34
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
80c2e34
to
ab3ffbe
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@rkavitha-hcl could you please point me to the change in the code where we are waiting for HALT method, only for pmon container to be killed? Also, could you modify the code such a way that if container is killed before timeout, can we return success? Please don't force push the changes. Thank you! |
The pmon container wait is in the sonic-host-services |
Thank you @kishanps |
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Added UT cases for Cold Reboot feature.
Added component tests for warm reboot.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)