Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ntpd to chrony #20497

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
86e1558
Add some initial changes for using chrony instead of NTP
saiarcot895 Jul 31, 2024
74b0084
Revert "[boot] Refactor: All services which start Docker containers s…
saiarcot895 Sep 2, 2024
0db82fe
Remove config files for NTP
saiarcot895 Sep 2, 2024
48d2d73
Update sonic-config-engine tests
saiarcot895 Sep 2, 2024
7cb9f40
Clean up config generation and update test output
saiarcot895 Sep 16, 2024
a4d7a09
Change whl and deb package installations to happen within chroot
saiarcot895 Sep 25, 2024
70a2f3b
Remove ntpstat, it doesn't work with chrony
saiarcot895 Sep 25, 2024
5f4168f
Listen on interface if source interface is specified or running in vrf
saiarcot895 Sep 27, 2024
2f5912d
Add startup script to chrony
saiarcot895 Oct 2, 2024
2176e9c
Don't let chrony step the clock
saiarcot895 Oct 2, 2024
ac76a44
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Oct 2, 2024
88c79ec
Fix chrony not getting started with `config reload`
saiarcot895 Oct 9, 2024
608b593
Remove unused config
saiarcot895 Oct 9, 2024
abcd875
Update test output
saiarcot895 Oct 9, 2024
695385d
Update sonic-host-services and sonic-utilities for chrony changes
saiarcot895 Oct 14, 2024
d33d1cd
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Oct 15, 2024
2bdec26
Have chrony manage the RTC instead of the kernel
saiarcot895 Oct 24, 2024
e49c622
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Nov 5, 2024
0995ae1
Add monit config to check NTP status
saiarcot895 Nov 7, 2024
9a4981e
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Jan 2, 2025
80002d6
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Jan 12, 2025
4818932
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Jan 23, 2025
c287263
Fix starting chrony in mgmt VRF by removing some protections
saiarcot895 Jan 24, 2025
8a550b7
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Feb 24, 2025
fb911bb
Bring in sonic-utilities changes
saiarcot895 Feb 24, 2025
d6568a4
Fix package installation
saiarcot895 Feb 26, 2025
149d8fa
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Mar 5, 2025
e01673a
Update sonic-utilities to bring in `sudo config ntp add` fix
saiarcot895 Mar 5, 2025
efde3c2
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Mar 5, 2025
fdfdab1
Fix initramfs installation
saiarcot895 Mar 6, 2025
8f5039c
Disable ntp check in monit
saiarcot895 Mar 7, 2025
9a7d4a0
Fix ntp config CLI
saiarcot895 Mar 7, 2025
50c1293
Merge remote-tracking branch 'origin/master' into use-chrony-ntp
saiarcot895 Mar 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions build_debian.sh
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,10 @@ sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install pigz
sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install busybox linux-base
echo '[INFO] Install SONiC linux kernel image'
## Note: duplicate apt-get command to ensure every line return zero
sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/initramfs-tools-core_*.deb || \
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f
sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/initramfs-tools_*.deb || \
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f
sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/linux-image-${LINUX_KERNEL_VERSION}-*_${CONFIGURED_ARCH}.deb || \
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f
sudo cp $debs_path/initramfs-tools-core_*.deb $debs_path/initramfs-tools_*.deb $debs_path/linux-image-${LINUX_KERNEL_VERSION}-*_${CONFIGURED_ARCH}.deb $FILESYSTEM_ROOT
basename_deb_packages=$(basename -a $debs_path/initramfs-tools-core_*.deb $debs_path/initramfs-tools_*.deb $debs_path/linux-image-${LINUX_KERNEL_VERSION}-*_${CONFIGURED_ARCH}.deb | sed 's,^,./,')
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt -y install $basename_deb_packages
( cd $FILESYSTEM_ROOT; sudo rm -f $basename_deb_packages )
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install acl
if [[ $CONFIGURED_ARCH == amd64 ]]; then
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install hdparm
Expand Down Expand Up @@ -233,7 +231,6 @@ echo '[INFO] Install docker'
## Install apparmor utils since they're missing and apparmor is enabled in the kernel
## Otherwise Docker will fail to start
sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install apparmor
sudo cp files/image_config/ntp/ntp-apparmor $FILESYSTEM_ROOT/etc/apparmor.d/local/usr.sbin.ntpd
sudo LANG=C chroot $FILESYSTEM_ROOT apt-get -y install apt-transport-https \
ca-certificates \
curl
Expand Down Expand Up @@ -333,7 +330,6 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in
vim \
tcpdump \
dbus \
ntpstat \
openssh-server \
python3-apt \
traceroute \
Expand Down Expand Up @@ -434,7 +430,7 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in
picocom \
systemd \
systemd-sysv \
ntp
chrony

if [[ $TARGET_BOOTLOADER == grub ]]; then
if [[ $CONFIGURED_ARCH == amd64 ]]; then
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/dhcp_relay.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requires=config-setup.service
After=config-setup.service swss.service syncd.service teamd.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/gnmi.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Description=GNMI container
Requires=database.service
After=database.service swss.service syncd.service
Before=ntp-config.service
BindsTo=sonic.target
After=sonic.target
StartLimitIntervalSec=1200
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/lldp.service.j2

This file was deleted.

1 change: 0 additions & 1 deletion files/build_templates/mgmt-framework.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requires=database.service
After=database.service swss.service syncd.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service

[Service]
User={{ sonicadmin_user }}
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/nat.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requires=config-setup.service
After=config-setup.service swss.service syncd.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/p4rt.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requires=database.service
After=database.service swss.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/bgp.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Requires=config-setup.service
After=config-setup.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
After=swss{% if multi_instance == 'true' %}@%i{% endif %}.service
After=interfaces-config.service
StartLimitIntervalSec=1200
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/gbsyncd.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ After=interfaces-config.service
After=swss{% if multi_instance == 'true' %}@%i{% endif %}.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service

[Service]
User=root
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/lldp.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ BindsTo=sonic.target
After=sonic.target
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/swss.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Requires=config-setup.service
After=config-setup.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/syncd.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ Requires=config-setup.service
After=config-setup.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
{% if sonic_asic_platform == 'mellanox' %}
Requires=nv-syncd-shared.service
After=nv-syncd-shared.service
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/per_namespace/teamd.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Requires=config-setup.service
After=config-setup.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/pmon.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ After=syncd.service
{% endif %}
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/radv.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
Description=Router advertiser container
Requires=config-setup.service
After=config-setup.service swss.service syncd.service
Before=ntp-config.service
BindsTo=sonic.target
After=sonic.target
StartLimitIntervalSec=1200
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/restapi.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requires=config-setup.service
After=config-setup.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service

[Service]
User={{ sonicadmin_user }}
Expand Down
1 change: 0 additions & 1 deletion files/build_templates/sflow.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Requisite=swss.service
After=swss.service syncd.service hostcfgd.service interfaces-config.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
1 change: 0 additions & 1 deletion files/build_templates/snmp.service.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Requisite=swss.service
After=config-setup.service swss.service syncd.service interfaces-config.service
BindsTo=sonic.target
After=sonic.target
Before=ntp-config.service
StartLimitIntervalSec=1200
StartLimitBurst=3

Expand Down
Loading
Loading