Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert clap upgrade and pin clap from being upgraded #42

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

AshwinSekar
Copy link
Contributor

No description provided.

@AshwinSekar AshwinSekar enabled auto-merge (squash) March 26, 2025 16:03
@joncinque
Copy link
Contributor

I was surprised that this one worked 😅 what's the issue?

@AshwinSekar AshwinSekar merged commit fda2d98 into solana-program:main Mar 26, 2025
7 checks passed
@AshwinSekar
Copy link
Contributor Author

I was surprised that this one worked 😅 what's the issue?

Got pinged because it looks like it broke the downstream test here https://github.com/anza-xyz/agave/actions/runs/14086477039/job/39451821947
the change on the agave side looks innocuous anza-xyz/agave#5499

@AshwinSekar
Copy link
Contributor Author

note: `ArgMatches` is defined in crate `clap_builder`
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.32/src/parser/matches/arg_matches.rs:67:1
    |
67  | pub struct ArgMatches {
    | ^^^^^^^^^^^^^^^^^^^^^
note: `ArgMatches` is defined in crate `clap`
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap-3.2.25/src/parser/matches/arg_matches.rs:68:1

@joncinque
Copy link
Contributor

Oh I see, the real issue is that there's no CI for the slashing CLI yet. If we add that, then CI will fail when trying to upgrade this next time, and not merge

@AshwinSekar
Copy link
Contributor Author

Ah, makes sense. I'll create an issue to add the CI #43

@AshwinSekar AshwinSekar deleted the ci branch March 26, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants