This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Fixed merchant e-mail validation edge case #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases paypal is not sending the receiver_email. In this particular case, instead of directly failing, let us at least test if the "business" parameter matches the merchant e-mail. This code has been tested in production environments.
|
We are no longer actively maintaining this library. We are open to transferring this repo to another organization with a track record of open source contributions and maintainership - I suggest the interested parties liaise and come up with a proposal. /cc @yalisassoon as technically this is Snowplow Analytics Ltd's IP. |
|
We rely on this library for many projects and this bug is causing us huge business problems, and I have submitted the fix. I know you are not actively maintaining it but would it still be possible to submit this fix? It wouldn't hurt anyone and would save us some precious time to not have to create a new fork of the library. Let me know. |
|
Any update on this? |
Fixed same domain paypal business
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases paypal is not sending the receiver_email. In this particular case, instead of directly failing, let us at least test if the "business" parameter matches the merchant e-mail. This code has been tested in production environments.