Skip to content

Commit

Permalink
fix for review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-ext-simba-hx committed Jan 25, 2025
1 parent 9e7e92f commit d5a760f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion php_pdo_snowflake_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,6 @@ enum {
#define PDO_SNOWFLAKE_CONN_ATTR_MAX_RETRIES_IDX 20
#define PDO_SNOWFLAKE_CONN_ATTR_RETRY_TIMEOUT_IDX 21
#define PDO_SNOWFLAKE_CONN_ATTR_OCSP_FAIL_OPEN_IDX 22
#define PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE 23
#define PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE_IDX 23

#endif /* PHP_PDO_SNOWFLAKE_INT_H */
6 changes: 3 additions & 3 deletions snowflake_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -825,14 +825,14 @@ pdo_snowflake_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{{ */
&SF_BOOLEAN_TRUE : &SF_BOOLEAN_FALSE);
PDO_LOG_DBG(
"ocspfailopen: %s",
vars[PDO_SNOWFLAKE_CONN_ATTR_INCLUDE_RETRY_REASON_IDX].optval);
vars[PDO_SNOWFLAKE_CONN_ATTR_OCSP_FAIL_OPEN_IDX].optval);

snowflake_global_set_attribute(SF_GLOBAL_OCSP_CHECK,
(strcasecmp(vars[PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE].optval, "true") == 0) ?
(strcasecmp(vars[PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE_IDX].optval, "true") == 0) ?
&SF_BOOLEAN_TRUE : &SF_BOOLEAN_FALSE);
PDO_LOG_DBG(
"disableocspchecks: %s",
vars[PDO_SNOWFLAKE_CONN_ATTR_INCLUDE_RETRY_REASON_IDX].optval);
vars[PDO_SNOWFLAKE_CONN_ATTR_OCSP_DISABLE_IDX].optval);

if (snowflake_connect(H->server) > 0) {
pdo_snowflake_error(dbh);
Expand Down

0 comments on commit d5a760f

Please sign in to comment.