Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of non-integer versions #353

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

dogversioning
Copy link
Contributor

@dogversioning dogversioning commented Feb 19, 2025

This addresses #306 by casting meta version numbers being of a non-integer numeric type by casting them through floats, then ints, to get them into the expected format for the aggregator.

Checklist

  • Consider if documentation in docs/ needs to be updated
    • If you've changed the structure of a table, you may need to run generate-md
    • If you've added/removed core study fields that not in US Core, update our list of those in core-study-details.md
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration in manifest.toml

Copy link

github-actions bot commented Feb 19, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2439 2439 100% 100% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_library/init.py 100% 🟢
cumulus_library/actions/uploader.py 100% 🟢
TOTAL 100% 🟢

updated for commit: e2670ca by action🐍

@dogversioning dogversioning merged commit 6eaf86a into main Feb 20, 2025
7 checks passed
@dogversioning dogversioning deleted the mg/coerce_meta_version branch February 20, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants