Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutover to rich for all console output #351

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Cutover to rich for all console output #351

merged 4 commits into from
Feb 12, 2025

Conversation

dogversioning
Copy link
Contributor

This PR adds the maintenance technical debt of 'check and see if there's a bare print statement before allowing a commit to occur', and implements #350

Checklist

  • Consider if documentation in docs/ needs to be updated
    • If you've changed the structure of a table, you may need to run generate-md
    • If you've added/removed core study fields that not in US Core, update our list of those in core-study-details.md
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration in manifest.toml

Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... good find in rich.print

Copy link

github-actions bot commented Feb 11, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2439 2439 100% 100% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_library/actions/builder.py 100% 🟢
cumulus_library/actions/cleaner.py 100% 🟢
cumulus_library/actions/importer.py 100% 🟢
cumulus_library/actions/uploader.py 100% 🟢
cumulus_library/base_utils.py 100% 🟢
cumulus_library/builders/counts.py 100% 🟢
cumulus_library/builders/valueset/vsac.py 100% 🟢
cumulus_library/cli.py 100% 🟢
cumulus_library/databases/duckdb.py 100% 🟢
cumulus_library/databases/utils.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 65b45b2 by action🐍

@dogversioning dogversioning merged commit 56a373a into main Feb 12, 2025
7 checks passed
@dogversioning dogversioning deleted the mg/rich_only branch February 12, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants