Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized jinja template entrypoint #177

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Centralized jinja template entrypoint #177

merged 4 commits into from
Feb 8, 2024

Conversation

dogversioning
Copy link
Contributor

This PR makes the following changes:

  • template_sql/base_templates now has a single entrypoint for rendering templates
    • This also supports loading templates from designated folders
    • As a result, everything going through this now gets access to macros
  • reorged all template renderers to go through this entrypoint
  • moved statistics templates to be a subfolder of statistics for pattern standardization

Checklist

  • Consider if documentation (like in docs/) needs to be updated - They do, I'm going to do that in one go.
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration

@dogversioning
Copy link
Contributor Author

I decided to not go crazy on moving additional macro snippets into shared locations, but it should be simple to do that going forward now.

@dogversioning dogversioning merged commit 31e0661 into main Feb 8, 2024
3 checks passed
@dogversioning dogversioning deleted the mg/jinja_utils branch February 8, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants