Cap max_date in the meta_date table to avoid Pandas bug #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't represent dates past 2262, which we sometimes have due to typos etc. Plus, it doesn't really makes sense to say that a run of the data metrics covers data in the future. So instead, we cap to CURRENT_DATE. No fix yet for typos deep in the past.
mikix
commented
Oct 11, 2024
| __version__ = "5.0.1" | ||
| __version__ = "5.1.0" |
There was a problem hiding this comment.
This fix itself feels like just a patch bump, but the other unreleased change is actually exporting the meta tables at all, which I had forgotten to do - so a minor bump felt appropriate (to me).
dogversioning
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can't represent dates past 2262, which we sometimes have due to typos etc.
Plus, it doesn't really makes sense to say that a run of the data metrics covers data in the future.
So instead, we cap to CURRENT_DATE. No fix yet for typos deep in the past.