q_ref_target_valid: change denominator from fields to rows #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we would count all potential matching Reference fields as the denominator. This commit aligns us back with the qualifier metric documentation to just use all rows as the denominator. In cases like DocumentReference.context.encounter that can have multiple references, we include the row once in the numerator and concatenate the target values for debugging.
dogversioning
approved these changes
May 29, 2024
| LEFT JOIN {{ dest }} AS dest | ||
| ON SUBSTRING(src.{{ field }}.reference, LENGTH('{{ dest }}/') + 1) = dest.id | ||
| WHERE | ||
| src.{{ field }}.reference LIKE '{{ dest }}/%' |
There was a problem hiding this comment.
reminder that we're supposed to use regexp() instead of LIKE for performance reasons.
There was a problem hiding this comment.
Ah yes thank you - filed #38 and I'll do that as a separate thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would count all potential matching Reference fields as the denominator. This commit aligns us back with the qualifier metric documentation to just use all rows as the denominator.
In cases like DocumentReference.context.encounter that can have multiple references, we include the row once in the numerator and concatenate the target values for debugging.
Noticed this discrepancy during a recent qualifier doc read-through.