Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Splits: parse AutoSplitterSettings from v4 #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Import Splits: parse AutoSplitterSettings from v4 #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions src/lib/lss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,6 @@ function parseAutoSplitterSettings(
autoSplitterSettings.getElementsByTagName("AutosplitStartRuns")[0];
const autosplitEndRuns =
autoSplitterSettings.getElementsByTagName("AutosplitEndRuns")[0];
const orderedStr = xmlDocOrdered && xmlDocOrdered.textContent?.trim();
const autoStart =
(autosplitStartRuns && autosplitStartRuns.textContent?.trim()) || "";
// autosplitIds vs splitIds: autosplitIds do not contain "-" for subsplits, splitIds can
const autosplitIds: Array<string> = [];
xmlDocSplits.childNodes.forEach((c) => {
Expand All @@ -322,14 +319,36 @@ function parseAutoSplitterSettings(
autosplitIds.push(autosplitId);
}
});
const endTriggeringAutosplit =
autosplitEndRuns && autosplitEndRuns.textContent?.trim() == "True";
return {
ordered: orderedStr == "True",
startTriggeringAutosplit: autoStart.length > 0 ? autoStart : undefined,
autosplitIds,
endTriggeringAutosplit,
};
if (xmlDocOrdered || autosplitStartRuns || autosplitEndRuns) {
// Default autosplitter version <= 3
const orderedStr = xmlDocOrdered && xmlDocOrdered.textContent?.trim();
const autoStart =
(autosplitStartRuns && autosplitStartRuns.textContent?.trim()) || "";
const endTriggeringAutosplit =
autosplitEndRuns && autosplitEndRuns.textContent?.trim() == "True";
return {
ordered: orderedStr == "True",
startTriggeringAutosplit: autoStart.length > 0 ? autoStart : undefined,
autosplitIds,
endTriggeringAutosplit,
};
} else {
// Default autosplitter version >= 4
const autoStart = autosplitIds[0] || "LegacyStart";
const autoEnd = autosplitIds[autosplitIds.length - 1] || "LegacyEnd";
const startTriggeringAutosplit =
autoStart != "LegacyStart" ? autoStart : undefined;
const endTriggeringAutosplit = autoEnd != "LegacyEnd";
return {
ordered: true,
startTriggeringAutosplit,
autosplitIds: autosplitIds.slice(
1,
endTriggeringAutosplit ? autosplitIds.length : autosplitIds.length - 1
),
endTriggeringAutosplit,
};
}
} else if (xmlDocCustomSettings) {
// WASM autosplitter
const xmlDocSettings = xmlDocCustomSettings.getElementsByTagName("Setting");
Expand Down
Loading