Mark tests as final #568
php.yml
on: push
Annotations
18 errors and 12 warnings
ClassMustBeFinal:
src/Auth/InvalidCredentialResult.php#L21
src/Auth/InvalidCredentialResult.php:21:7: ClassMustBeFinal: Class SimpleSAML\Module\ldap\Auth\InvalidCredentialResult is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L28
src/Auth/InvalidCredentialResult.php:28:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::LDAP_NO_SUCH_OBJECT" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L29
src/Auth/InvalidCredentialResult.php:29:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_LOGON_FAILURE" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L30
src/Auth/InvalidCredentialResult.php:30:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_ACCOUNT_RESTRICTION" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L31
src/Auth/InvalidCredentialResult.php:31:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_INVALID_LOGON_HOURS" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L32
src/Auth/InvalidCredentialResult.php:32:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_INVALID_WORKSTATION" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L33
src/Auth/InvalidCredentialResult.php:33:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_PASSWORD_EXPIRED" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L34
src/Auth/InvalidCredentialResult.php:34:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_ACCOUNT_DISABLED" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L35
src/Auth/InvalidCredentialResult.php:35:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_TOO_MANY_CONTEXT_IDS" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/Auth/InvalidCredentialResult.php#L36
src/Auth/InvalidCredentialResult.php:36:18: MissingClassConstType: Class constant "SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::ERROR_ACCOUNT_EXPIRED" should have a declared type. (see https://psalm.dev/359)
|
UnusedClass:
tests/src/Auth/Process/BaseFilterTest.php#L11
tests/src/Auth/Process/BaseFilterTest.php:11:13: UnusedClass: Class SimpleSAML\Test\Module\ldap\Auth\Process\BaseFilterTest is never used (see https://psalm.dev/075)
|
UnusedMethodCall:
tests/src/Auth/Process/BaseFilterTest.php#L20
tests/src/Auth/Process/BaseFilterTest.php:20:18: UnusedMethodCall: The call to ReflectionMethod::setAccessible is not used (see https://psalm.dev/209)
|
UnusedClass:
tests/src/Auth/Source/LdapTest.php#L13
tests/src/Auth/Source/LdapTest.php:13:13: UnusedClass: Class SimpleSAML\Module\ldap\Auth\Source\LdapTest is never used (see https://psalm.dev/075)
|
MissingOverrideAttribute:
tests/src/Auth/Source/LdapTest.php#L17
tests/src/Auth/Source/LdapTest.php:17:5: MissingOverrideAttribute: Method SimpleSAML\Module\ldap\Auth\Source\LdapTest::setupbeforeclass should have the "Override" attribute (see https://psalm.dev/358)
|
UnusedClass:
tests/src/Connector/ConnectorFactoryTest.php#L20
tests/src/Connector/ConnectorFactoryTest.php:20:13: UnusedClass: Class SimpleSAML\Test\Module\ldap\Connector\ConnectorFactoryTest is never used (see https://psalm.dev/075)
|
MissingOverrideAttribute:
tests/src/Connector/ConnectorFactoryTest.php#L24
tests/src/Connector/ConnectorFactoryTest.php:24:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\ldap\Connector\ConnectorFactoryTest::setupbeforeclass should have the "Override" attribute (see https://psalm.dev/358)
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L1
/home/runner/work/simplesamlphp-module-ldap/simplesamlphp-module-ldap/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
|
Quality control
Process completed with exit code 2.
|
Security checks
Cache not found for keys: Linux-composer-, Linux-composer-
|
Quality control
Cache not found for keys: Linux-composer-, Linux-composer-
|
PossiblyUnusedMethod:
src/Auth/InvalidCredentialResult.php#L139
src/Auth/InvalidCredentialResult.php:139:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::getCode (see https://psalm.dev/087)
|
PossiblyUnusedMethod:
src/Auth/InvalidCredentialResult.php#L150
src/Auth/InvalidCredentialResult.php:150:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::getRawMessage (see https://psalm.dev/087)
|
PossiblyUnusedMethod:
src/Auth/InvalidCredentialResult.php#L161
src/Auth/InvalidCredentialResult.php:161:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::updateCodeMap (see https://psalm.dev/087)
|
PossiblyUnusedMethod:
src/Auth/InvalidCredentialResult.php#L173
src/Auth/InvalidCredentialResult.php:173:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\InvalidCredentialResult::replaceCodeMap (see https://psalm.dev/087)
|
UnusedClass:
src/Auth/Process/AttributeAddFromLDAP.php#L19
src/Auth/Process/AttributeAddFromLDAP.php:19:7: UnusedClass: Class SimpleSAML\Module\ldap\Auth\Process\AttributeAddFromLDAP is never used (see https://psalm.dev/075)
|
UnusedClass:
src/Auth/Process/AttributeAddUsersGroups.php#L21
src/Auth/Process/AttributeAddUsersGroups.php:21:7: UnusedClass: Class SimpleSAML\Module\ldap\Auth\Process\AttributeAddUsersGroups is never used (see https://psalm.dev/075)
|
PropertyNotSetInConstructor:
src/Auth/Process/AttributeAddUsersGroups.php#L56
src/Auth/Process/AttributeAddUsersGroups.php:56:21: PropertyNotSetInConstructor: Property SimpleSAML\Module\ldap\Auth\Process\AttributeAddUsersGroups::$additional_filters is not defined in constructor of SimpleSAML\Module\ldap\Auth\Process\AttributeAddUsersGroups or in any methods called in the constructor (see https://psalm.dev/074)
|
PossiblyUnusedMethod:
src/Auth/Source/Ldap.php#L181
src/Auth/Source/Ldap.php:181:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\Source\Ldap::getAttributes (see https://psalm.dev/087)
|
PossiblyUnusedMethod:
src/Auth/Source/Ldap.php#L282
src/Auth/Source/Ldap.php:282:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\ldap\Auth\Source\Ldap::getConnector (see https://psalm.dev/087)
|
UnusedClass:
src/Auth/Source/LdapMulti.php#L27
src/Auth/Source/LdapMulti.php:27:7: UnusedClass: Class SimpleSAML\Module\ldap\Auth\Source\LdapMulti is never used (see https://psalm.dev/075)
|