Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW ElementControllers extension point. #1322

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Feb 25, 2025

ElementControllers extension point.

Description

Add an extension point for more flexibility.

Related Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 25, 2025

There's ongoing discussion about this change in the linked issue - but please note that the beta for CMS 5.4 has been released (we're just in the process of finalising it) so this change will need to target the 6.0 branch.

@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/elemental-controllers-extension branch from ad2df2d to 238617f Compare February 25, 2025 20:56
@mfendeksilverstripe mfendeksilverstripe changed the base branch from 5 to 6.0 February 25, 2025 20:57
@mfendeksilverstripe
Copy link
Contributor Author

Rebased now @GuySartorelli

@GuySartorelli
Copy link
Member

Looks like you changed the base branch after pushing, so CI still thinks it should be testing against 5 even though the code is for 6. Can you please force push again so CI can run against the correct branch?

@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/elemental-controllers-extension branch from 238617f to a7787d2 Compare February 25, 2025 21:03
@mfendeksilverstripe
Copy link
Contributor Author

Done @GuySartorelli

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 68bf9ab into silverstripe:6.0 Feb 25, 2025
24 checks passed
@mfendeksilverstripe mfendeksilverstripe deleted the feature/elemental-controllers-extension branch February 25, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants