Feature/undo refactor #49

sillydan1 · 2024-03-21T21:18:19Z

This PR refactors the undo system majorly:

Changes

Undo system is now based on a tree datastructure
Graphedit undo systems are now observable
Undo systems are now instantiated on a per-buffer basis rather than one global system
Add a new undo-system inspector (and branch switcher) to the std plugin

This PR fixes #1

also added snapshot ability (experimental)

BREAKING CHANGE: This breaks the public API a bit, but the fix is easy by simply getting the undosystem from a buffer (obtained through the IBufferContainer class) rather than through the DI system

core/src/main/java/dk/gtz/graphedit/util/ObservableTreeUndoSystem.java

core/src/main/java/dk/gtz/graphedit/viewmodel/DiffUndoable.java

core/src/main/java/dk/gtz/graphedit/viewmodel/ViewModelProjectResource.java

graphedit/src/main/java/dk/gtz/graphedit/Main.java

graphedit/src/main/java/dk/gtz/graphedit/view/GraphEditApplication.java

std/src/main/java/dk/gtz/graphedit/plugins/UndoTreePanel.java

std/src/main/java/dk/gtz/graphedit/plugins/view/UndoTreePanelController.java

It might still be relevant in the future, but not right now

sillydan1 added 8 commits March 16, 2024 11:21

feat: add undo tree panel to std

93a5450

also added snapshot ability (experimental)

feat!: make the undo system per-buffer

bc898de

BREAKING CHANGE: This breaks the public API a bit, but the fix is easy by simply getting the undosystem from a buffer (obtained through the IBufferContainer class) rather than through the DI system

feat: add currently focused buffer to buffercontainer construct

9b95af3

feat: display the undo stack

a79c33c

feat: add observable tree undo system

043d4cb

feat: clickable undo elements

ddc6ca6

fix: edgecase where the latest undoable couldn't be selected

1607b47

fix: slightly prettier branches and better ux

e4100a8

sillydan1 added the enhancement New feature or request label Mar 21, 2024

sillydan1 self-assigned this Mar 21, 2024

sillydan1 changed the base branch from main to dev March 21, 2024 21:19

sillydan1 commented Mar 21, 2024

View reviewed changes

sillydan1 added 3 commits March 22, 2024 06:46

nit: changes from code review

6e98390

fix: remove snapshot experiment

58b4aaf

It might still be relevant in the future, but not right now

fix: only add one event handler to the undo history panel list

92696c5

sillydan1 merged commit 20cd4df into dev Mar 22, 2024
3 checks passed

sillydan1 deleted the feature/undo-refactor-#1 branch March 22, 2024 06:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/undo refactor #49

Feature/undo refactor #49

sillydan1 commented Mar 21, 2024

Feature/undo refactor #49

Feature/undo refactor #49

Conversation

sillydan1 commented Mar 21, 2024

Changes