Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-38141 Python 2 removal #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SG-38141 Python 2 removal #33

wants to merge 3 commits into from

Conversation

eduardoChaucaGallegos
Copy link
Contributor

@eduardoChaucaGallegos eduardoChaucaGallegos commented Feb 20, 2025 •
edited
Loading

Description

  • Super format updated
  • Removed __ future_ imports.
  • ensure_str() by str()

Tests

  • File Open
    image
  • File Save
    image
  • Publish
    image
  • Panel

carlos-villavicencio-adsk
carlos-villavicencio-adsk approved these changes Feb 20, 2025
View reviewed changes
hooks/tk-multi-publish2/basic/start_version_control.py Outdated
@@ -281,7 +276,7 @@ def _session_path():
:return:
"""
path = mb_app.FBXFileName
path = sgutils.ensure_str(path)
path = str(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify this function in just one line:

    return str(mb_app.FBXFileName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lang julien-lang julien-lang approved these changes

@carlos-villavicencio-adsk carlos-villavicencio-adsk carlos-villavicencio-adsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardoChaucaGallegos @julien-lang @carlos-villavicencio-adsk