SG-35999 Create a hook for socketIO prepare_http_session #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hook change the requests.session instance setting trust_env to False and therefore not using the system proxy settings
carlos-villavicencio-adsk
approved these changes
Feb 4, 2025
eduardoChaucaGallegos
approved these changes
Feb 4, 2025
staceyoue
approved these changes
Feb 4, 2025
staceyoue
requested changes
Feb 5, 2025
staceyoue
reviewed
Feb 5, 2025
staceyoue
approved these changes
Feb 5, 2025
carlos-villavicencio-adsk
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook changes the
requests.sessioninstance settingtrust_envto False and therefore not using the system proxy settings.Add an
SGTK_ENFORE_PROXY_LOCALHOSTenvironment variable to recover the legacy behaviour.Related to shotgunsoftware/tk-alias#208 and shotgunsoftware/tk-framework-alias#83.