Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace set-output command with environment files #1086

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kieran-smith77
Copy link
Contributor

Pull Request

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • pre-commit was run locally and any changes were pushed
  • test/test.sh has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

entrypoint.sh currently uses set-output to return the output of sarifContentRepo. This creates a warning on any workflow currently using this action.

Issue URL: #1085

What is the new behavior?

  • Replaces set-output with environment files in entrypoint.sh

Does this introduce a breaking change?

  • Yes
  • No

Other information

@kieran-smith77 kieran-smith77 marked this pull request as ready for review November 20, 2024 17:37
@martinm82
Copy link

Can we please approve and merge this PR

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 24, 2025
@tomwillis608
Copy link
Member

Thanks for this code improvement

@tomwillis608 tomwillis608 merged commit b8b4b39 into sett-and-hive:main Feb 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants