Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scrapers): Van Gogh scraper #311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(scrapers): Van Gogh scraper #311

wants to merge 3 commits into from

Conversation

jalerson
Copy link

Hello,

Here is my solution for the coding test.

  • The generic scraper intends to scrape simple data like the name, extension and the link
  • Scraping the image required more logic to get the real image instead of the placeholder, so there is a dedicated scraper for it
  • The gallery scraper is composed by other scrapers
  • Every scraper allows customization/extension, making them very open-closed compliant

I hope you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jalerson