Invert parameters in apply-schema so we can validate schema type based on composable parameters #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters with parser output
Co-authored-by: Guga Guichard <gustavoguichard@gmail.com>
is not compatible with the schema. It's a sad day for our typing, but we have to release a major to stop using currying in applySchema so we can do some proper type-checking.
…d on composable parameters
diogob
force-pushed
the
explit-return-types
branch
2 times, most recently
from
8c7ca00 to
1c3a78b
Compare
|
we might reopen this in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rough draft, still need to update examples and docs
not so sure about this one though, perhaps it is best to keep the current solution. I'm leaving the PR open so we can contemplate de diff a while longer.