Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add counter based CCC logger #970

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak requested review from lispc and darth-cy August 9, 2024 11:42
@omerfirmak omerfirmak force-pushed the omerfirmak/one-pass-ccc branch 3 times, most recently from 8fd91ec to 9a1a673 Compare August 10, 2024 11:51
@0xmountaintop
Copy link

do you read the circuit codes to summarize these usages?
I think it will also be great if we can make a document to list these usages.

@omerfirmak
Copy link
Author

do you read the circuit codes to summarize these usages?

I think it will also be great if we can make a document to list these usages.

They were provided by @darth-cy

@omerfirmak omerfirmak force-pushed the omerfirmak/one-pass-ccc branch from f7b07a9 to 68d277e Compare August 12, 2024 06:17
@omerfirmak omerfirmak changed the base branch from develop to feat/lightweight-ccc August 13, 2024 12:33
@omerfirmak omerfirmak merged commit 3addaa2 into feat/lightweight-ccc Aug 13, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/one-pass-ccc branch August 13, 2024 13:24
omerfirmak added a commit that referenced this pull request Aug 22, 2024
omerfirmak added a commit that referenced this pull request Aug 22, 2024
omerfirmak added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants