Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(miner,rpc): fix updateSnapshot #916

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

0xmountaintop
Copy link

1. Purpose or design rationale of this PR

updateSnapshot not only for the non-sequencer but also for the sequencer, to serve the pending block tag.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop requested a review from omerfirmak July 23, 2024 07:15
omerfirmak
omerfirmak previously approved these changes Jul 23, 2024
@Thegaram Thegaram self-requested a review July 23, 2024 08:57
@0xmountaintop 0xmountaintop changed the title fix(rpc): fix updateSnapshot fix(miner,rpc): fix updateSnapshot Jul 23, 2024
Thegaram
Thegaram previously approved these changes Jul 23, 2024
@github-actions github-actions bot dismissed stale reviews from Thegaram and omerfirmak via 34e3c95 July 23, 2024 14:21
@0xmountaintop 0xmountaintop merged commit 9ee6976 into develop Jul 23, 2024
@0xmountaintop 0xmountaintop deleted the HAOYUatHZ-patch-2 branch July 23, 2024 14:22
achmand pushed a commit to draganm/go-ethereum that referenced this pull request Aug 13, 2024
* fix `updateSnapshot`

* fix

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* fix `updateSnapshot`

* fix

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants