Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ATLAS Physlite file for uproot #171

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

ArturU043
Copy link
Contributor

Adding an ATLAS derivation file PHYSLITE for uproot CI tests.
The file contains 100 events in the RNTuple format (EventData).

File built with ROOT 6.34.04 and validated for testing with uproot 5.5.1

Artur Cordeiro Oudot Choi and others added 2 commits March 3, 2025 11:19
Co-authored-by: Tatiana Ovsiannikova <TatianaOvsiannikova@users.noreply.github.com>
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (1895e34) to head (9ad8c41).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files           3        3           
  Lines         134      134           
=======================================
  Hits           97       97           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariostas
Copy link
Collaborator

ariostas commented Mar 3, 2025

@ArturU043 thanks for this PR! Just a couple of things:

  • Do you know if this PHYSLITE format is relatively finalized? It seems to me like it is not particularly well designed for RNTuple, and I've heard that there's discussions to improve it. Is there some sort of versioning that PHYSLITE uses that we could use to tag this file. The issue is that if the format is updated later we can't simply replace the file since the way this package is set up has some issues with file replacement, so we would need to give it a new name.
  • Could you replace the rntp in the naming with rntuple_v1-0-0-0 so that we can more easily keep track of which RNTuple version it is written with?

@ariostas ariostas self-requested a review March 3, 2025 14:18
@ArturU043
Copy link
Contributor Author

Hi @ariostas

The current version is indeed V1.0.0.0. Some developers are working on fixing some issues with metadata collection with the root Python API, but the current version is practically production-ready. If major changes arise, we can add a new file.

Concerning the first point, this Physlite format is stable for the current Atlas analysis Software releases. The format might be improved in the future with RNtuple compatibility in mind...
In any case, this file's Physlite format is used in many current and future analyses. If the Physlite data structure changes drastically, it won't be so soon.

I changed the file name as you requested.

@ariostas ariostas changed the title ATLAS Physlite file for uproot feat: ATLAS Physlite file for uproot Mar 4, 2025
@ariostas ariostas merged commit d433fe3 into scikit-hep:main Mar 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants