Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tests passing again #269

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix: make tests passing again #269

merged 5 commits into from
Feb 14, 2024

Conversation

chrispap95
Copy link
Collaborator

@chrispap95 chrispap95 commented Feb 13, 2024

Solves issue #268.
Edit:
Changelog:

  • Get rid of nested ak.zip( ak.Record() ) in the tests after @jpivarski 's suggestion.
  • Double the expected number of constituents in the test_exclusive_jets_softdrop_grooming_multi
  • Update boost to v1.84
  • Update CGAL to v5.6

@chrispap95
Copy link
Collaborator Author

Actually, I have no idea how the test_exclusive_jets_softdrop_grooming_multi test was passing before. It obviously needs to double the constituents.

@chrispap95
Copy link
Collaborator Author

The reason why the mac os test is failing is because of this: CGAL/cgal@294f5b7
In other words, bad interplay between boost 1.84 and CGAL 5.X.

@chrispap95 chrispap95 changed the title fix: solve issue with ak.zip and ak.Record fix: make tests passing again Feb 14, 2024
@chrispap95 chrispap95 requested a review from lgray February 14, 2024 11:38
@chrispap95 chrispap95 linked an issue Feb 14, 2024 that may be closed by this pull request
@lgray lgray merged commit 7b114a1 into main Feb 14, 2024
13 checks passed
@lgray lgray deleted the fix_268 branch February 14, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests are broken
2 participants