Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify types #43

Closed
wants to merge 7 commits into from
Closed

Simplify types #43

wants to merge 7 commits into from

Conversation

schnellerhase
Copy link
Owner

@schnellerhase schnellerhase commented Feb 17, 2025

Contains multiple changes to the type system.

  1. Generalizes dolfinx::scalar concept to allow for general std::complex<T> types (before only float and double supported).
  2. Renames trait dolfinx::scalar_value_type to dolfinx::scalar_value and its short notation scalar_value_type_t to scalar_value_t (removes duplicate 'type'). Also renames internal trait variable from value_type to type to highlight different implications.
  3. Introduces DofMapSpan type in types.h in favor of multiple definitions of mdspan2_t types. (This caused undefined definition errors when including assembler implementation files)
  4. Introduce namespace alias md for MDSPAN_IMPL_STANDARD_NAMESPACE - following style chosen in Simplify mdspan namespace FEniCS/basix#902 (should one globally rename MDSPAN_IMPL_STANDARD_NAMESPACE to md with this?)

@schnellerhase schnellerhase force-pushed the simplify_types branch 2 times, most recently from d8884c2 to f274ad0 Compare February 17, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant