Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a new ml dirichlet field and making bc names consistent. #42

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

cmhamel
Copy link
Collaborator

@cmhamel cmhamel commented Jan 26, 2025

No description provided.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 72 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (6036b68) to head (eddb597).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pancax/networks/ml_dirichlet_field.py 15.66% 70 Missing ⚠️
pancax/loss_functions/bc_loss_functions.py 0.00% 1 Missing ⚠️
pancax/problems/inverse_problem.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   66.43%   65.29%   -1.14%     
==========================================
  Files          85       86       +1     
  Lines        3593     3677      +84     
==========================================
+ Hits         2387     2401      +14     
- Misses       1206     1276      +70     
Flag Coverage Δ
unittests 65.29% <30.76%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmhamel cmhamel merged commit 3385e23 into main Jan 26, 2025
4 of 6 checks passed
@cmhamel cmhamel deleted the bc-name-consistency branch January 26, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant