feat: Create a initial docker container for FIREWHEEL #68
Conversation
Signed-off-by: Steven Elliott <6461548+sdelliot@users.noreply.github.com>
| /usr/share/openvswitch/scripts/ovs-ctl start 1>/var/log/minimega.log 2>/var/log/minimega.log | ||
| if [ $? -ne 0 ]; then | ||
| echo "Failed to start Open vSwitch" 1> /var/log/minimega.log | ||
| fi | ||
|
|
||
| # Check if Minimega is already running | ||
| if pgrep -f "/opt/minimega/bin/minimega" > /dev/null; then | ||
| echo "Minimega is already running. Exiting script." 1> /var/log/minimega.log | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
@GhostofGoes and @jacdavi do you think that minimega would benefit from these additions to the start-minimega.sh or do you think it would cause a loss of functionality?
There was a problem hiding this comment.
Interesting, I see a warning from time to time about minimega already running (when deployed with minimega+phenix). In what circumstances does this happen?
There was a problem hiding this comment.
The primary logic change is exiting the when minimega is already running. We call this script to start minimega when clearing our testbed, but if minimega (and miniweb) are still running, that isn't a useful action. Especially as trying to start multiple instances of minimega/miniweb seemed to cause issues (even with -force True).
| WORKDIR / | ||
|
|
||
| # Install discovery | ||
| RUN wget https://github.com/mitchnegus/minimega-discovery/releases/download/firewheel-debian_faed761/discovery.deb && \ |
There was a problem hiding this comment.
Is this where we want to be pulling from?
There was a problem hiding this comment.
Eventually, we want to pull from https://github.com/sandia-minimega/discovery/ but a new release hasn't been issued yet. I plan on pinging them on this offline.
This PR provides a working Docker container for FIREWHEEL. We should consider this as a beta-testing phase and remove that label in a future release. This container has been tested in both low-trust and high-trust environments where various permissions/kernel modules were stripped and verified functionality. The associated documentation provides a good overview of the container and how it was created.
Aside from that, there are a few important things to note: