Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin to support latest Jenkins and Sentry version #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kuzaxak
Copy link
Collaborator

@kuzaxak kuzaxak commented Oct 3, 2023

Sentry SDK was updated to the latest one together with cleaning up unused code. Logger handler now is a dedicated dependency that should be listed.

More in the doc.

Jenkins BOM is taken from article

Sentry SDK was updated to the latest one together with cleaning up unused code.
Logger handler now is a dedicated dependency that should be listed.

More in the [doc][1].

Jenkins BOM is taken from [article][2]

[1]: https://docs.sentry.io/platforms/java/guides/jul/
[2]: https://www.jenkins.io/doc/developer/plugin-development/dependency-management/
@kuzaxak kuzaxak requested a review from a team October 3, 2023 15:07
Sentry.init()

System.env.each { key, value ->
key.eachMatch('SENTRY_TAG_(\\w+)') { match ->
Copy link

@anna-agafonova anna-agafonova Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is done by SDK in modern versions

Copy link

@anna-agafonova anna-agafonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants