-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #321
Update dependencies #321
Conversation
Looks like there are a few CI failures :-/ stable 7 months ago is too old for base64ct:
and the
|
I've reverted the botan upgrade (sticking with 0.11.0 instead of moving to 0.11.1) and filed an issue. For the base64ct failure, I've chosen to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the botan upgrade (sticking with 0.11.0 instead of moving to 0.11.1) and filed randombit/botan-rs#144.
Thank you!
For the base64ct failure, I've chosen to remove the rsa-irc example that was relying on the rsa crate (which in turn relies on the base64ct crate). This also removes the need for rand, so it seems like a nice simplification.
I'm a 👍 on that. It feels like this example was more important when there wasn't a way to generate RSA private keys w/ rcgen (because of ring
limitations). Since that's now handled by aws-lc-rs
support and the rsa
crate has unresolved vulnerabilities (and RSA is a poor choice in 2025 generally) it seems like an obvious choice to remove it.
# This greatly speeds up rsa key generation times | ||
# (only applies to the dev-dependency of rcgen because cargo | ||
# ignores profile overrides for non leaf packages) | ||
[profile.dev.package.num-bigint-dig] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose removing this is okay because we now have aws-lc-rs which can also do rsa keygen.
No description provided.