Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.0, add AcmeRenewalInfoCertIdentifier #75

Closed
wants to merge 2 commits into from

Conversation

cpu
Copy link
Member

@cpu cpu commented Feb 22, 2025

Note to reviewers: Opened as a draft while we look at the end-to-end integration in djc/instant-acme#85

Adds a new AcmeRenewalInfoCertIdentifier struct that holds two Der fields that can be used to uniquely identify a certificate.

The contained data is necessary to implement an extension to ACME/RFC-8555, ACME Renewal Information (ARI).

For the purposes of ARI the end-state of this structure is a BASE64 URL-safe encoded URL used to identify the certificate when replacing it with a new order. Since pki-types only offers an internal BASE64 decoder this task is left to consumers to implement with their b64 lib of choice.

See the Let's Encrypt support announcement for more information on the general utility of ARI.

Suggested release notes

cpu added 2 commits February 22, 2025 12:35
Adds a new `AcmeRenewalInfoCertIdentifier` struct that holds two `Der`
fields that can be used to uniquely identify a certificate.

The contained data is necessary to implement an extension to
ACME/RFC-8555, ACME Renewal Information (ARI):

  https://www.ietf.org/archive/id/draft-ietf-acme-ari-07.html

For the purposes of ARI the end-state of this structure is a BASE64
URL-safe encoded URL used to identify the certificate when replacing it
with a new order. Since `pki-types` only offers an internal BASE64
_decoder_ this task is left to consumers to implement with their b64 lib
of choice.
@cpu
Copy link
Member Author

cpu commented Feb 23, 2025

Initially I was thinking this was an OK fit for this crate along similar logic as the SubjectPublicKeyInfoDer struct, but in retrospect I think there aren't likely to be meaningful cross-crate usages at this time. Going to close this and just put the type downstream.

@cpu cpu closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant