Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION #4259

Merged
merged 6 commits into from
Mar 19, 2025
Merged

feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION #4259

merged 6 commits into from
Mar 19, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Mar 19, 2025 •
edited
Loading

Closes #1158.

I think the following console log should suffice to explain what this PR does (no tests for the .sh script, but works on my machine):

> RUSTUP_VERSION=1.26.0 ./rustup-init.sh --version
info: `RUSTUP_VERSION` has been set to `1.26.0`
info: downloading installer
rustup-init 1.26.0 (5af9b9484 2023-04-05)

The same environment variable now also applies to rustup self update, which does come with a proper test.

@rami3l rami3l requested review from djc and ChrisDenton March 19, 2025 14:13
@rami3l rami3l changed the title feat: allow arbitrary downgrade via the RUSTUP_VERSION environment variable feat: allow version pinning/arbitrary downgrade RUSTUP_VERSION Mar 19, 2025
@rami3l rami3l changed the title feat: allow version pinning/arbitrary downgrade RUSTUP_VERSION feat: allow version pinning/arbitrary downgrade via RUSTUP_VERSION Mar 19, 2025
@rami3l rami3l changed the title feat: allow version pinning/arbitrary downgrade via RUSTUP_VERSION feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION Mar 19, 2025
ChrisDenton
ChrisDenton reviewed Mar 19, 2025
View reviewed changes
rami3l
rami3l commented Mar 19, 2025
View reviewed changes
@rami3l rami3l enabled auto-merge March 19, 2025 15:22
@rami3l rami3l added this pull request to the merge queue Mar 19, 2025
Merged via the queue into rust-lang:master with commit 3b60eb2 Mar 19, 2025
29 checks passed
@rami3l rami3l deleted the feat/downgrade branch March 19, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

@djc djc Awaiting requested review from djc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make downgrading via the archives work
2 participants
@rami3l @ChrisDenton