-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alternative QNX Neutrino network stack io-sock
#4169
base: main
Are you sure you want to change the base?
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
b9d6917
to
3f75bbc
Compare
☔ The latest upstream changes (presumably #4198) made this pull request unmergeable. Please resolve the merge conflicts. |
273da82
to
2410b84
Compare
☔ The latest upstream changes (presumably #4202) made this pull request unmergeable. Please resolve the merge conflicts. |
6e08444
to
f92715a
Compare
21b7555
to
c0d8cf1
Compare
@tgross35 would it make sense to take over from @JohnTitor ? Asking because of 65d0ffb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the nto changes too deeply since I have nothing to reference, but the surface looks reasonable to me and you are a target maintainer. @jonathanpallant you're also listed as a maintainer, could you ack this?
Also, looks like the first two commits could be squashed |
c0d8cf1
to
ff5a039
Compare
Done. The test failures of freebsd tests seem to be unrelated. |
ff5a039
to
f2b8ec3
Compare
Signed-off-by: Florian Bartels <Florian.Bartels@elektrobit.com>
f2b8ec3
to
720b515
Compare
Description
QNX 7.1 supports two network stacks:
io-pkt
, which is defaultio-sock
, which is optional and should be default in QNX 8.0As one can see in the io-sock migration notes, this changes the libc API in a way similar to e.g. linux-gnu vs. linux-musl.
This change uses a new target which has a different value for
target_env
, so that e.g. libc can distinguish between both APIs. New target pull request for rustc: rust-lang/rust#133631CC: @jonathanpallant @japaric @gh-tr @AkhilTThomas
Sources
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI