Vendor Bitcoin Core v23.2 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lol, a different variant of the same bug. I wonder if there's a newer version of the s390x image we could be using? Or a different big-endian box? I seem to remember Github discontinuing s390x many years ago.. I'm surprised this is still running for us. |
Yeah I had a bit of a scout around and didn't see one - I can look harder though. |
|
For now I think we should just mark this CI job as optional :/. Let's get caught up with Core and then revisit this rather than having this open loop where we're struggling to deal with old code on old CI boxes and unable to move forward. |
|
Let's go! |
tcharding
force-pushed
the
01-19-vendor-core-23.2
branch
from
fbd3bcc to
16569fb
Compare
Run the vendoring script: `./contrib/vendor-bitcoin-core.sh v23.2`
tcharding
force-pushed
the
01-19-vendor-core-23.2
branch
from
16569fb to
1b8dd2e
Compare
|
Gentle bump, can you take a look at this one please @apoelstra. |
apoelstra
approved these changes
Feb 2, 2024
|
Is this queued up for merge today @apoelstra ? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the vendoring script:
./contrib/vendor-bitcoin-core.sh v23.2