Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE-MIT #211

Closed
wants to merge 2 commits into from
Closed

Conversation

maximevtush
Copy link

Updated the copyright year from 2017 to 2025 in the LICENSE file

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7ccf7e8; successfully ran local tests; fine by me

@tcharding
Copy link
Member

Written ok from me in relation to any work I have done on this crate - if such a thing is needed.

@clarkmoody
Copy link
Member

According to this random Stack Exchange answer, the copyright year should be either the year the license went into effect or a range (e.g. 2017-2025).

@maximevtush maximevtush requested a review from apoelstra January 30, 2025 05:13
@tcharding
Copy link
Member

What is the benefit of this now? Do we have to update the 2025 every year? That seems like a step backwards.

@maximevtush
Copy link
Author

What is the benefit of this now? Do we have to update the 2025 every year? That seems like a step backwards.

i can delete the Copyright year fully

@tcharding
Copy link
Member

Perhaps make a case for why this change is needed in the first place otherwise it looks to me like its not. I am not a lawer and have zero interest in copyright, I care about maintainability though.

@tcharding
Copy link
Member

I can't spell either.

@apoelstra
Copy link
Member

Do we have to update the 2025 every year?

I think we should try to remember to do it every decade or so, as long as the project is maintained. In theory if we have a super old date such that a copyright from that date would've lapsed, somebody could claim they thought the work had fallen into the public domain.

But IANAL and I also really don't think this matters.

I would not advise deleting the year unless there is a clear reason for it.

@maximevtush
Copy link
Author

Do we have to update the 2025 every year?

I think we should try to remember to do it every decade or so, as long as the project is maintained. In theory if we have a super old date such that a copyright from that date would've lapsed, somebody could claim they thought the work had fallen into the public domain.

But IANAL and I also really don't think this matters.

I would not advise deleting the year unless there is a clear reason for it.

what actions should I take?

@tcharding
Copy link
Member

Does the 2017 go stale some time? Like 10 years (2027)?

@apoelstra
Copy link
Member

I think it "goes stale" 70 years after Clark dies :P.

@tcharding
Copy link
Member

Mad, I'll be dead then too. Lets just leave it as it is then huh.

@clarkmoody
Copy link
Member

I think it "goes stale" 70 years after Clark dies :P.

👀

@clarkmoody
Copy link
Member

Really though, I don't think this matters, and we should probably just close this PR.

@maximevtush
Copy link
Author

Really though, I don't think this matters, and we should probably just close this PR.

maybe merge?

@tcharding tcharding closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants