Introduce crate level decoding functions #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulled out of #162 |
tcharding
added a commit
to tcharding/hex-conservative
that referenced
this pull request
Mar 3, 2025
WIP because this should come from `master` but we are waiting on rust-bitcoin#166 to merge. `master` is at tip: TOOD Introduce decoding logic from `master`, this means: Public API consisting of: - The crate level decoding functions - The associated error types Private code: - Code in private modules `parse` and `iter` as needed.
tcharding
force-pushed
the
03-04-decodeing-api
branch
2 times, most recently
from
c9531ac to
e50d71c
Compare
We would like to release a bare-bones 1.0 version of this crate that excludes the `FromHex` trait. So that users can still decode vectors and arrays without the trait introduced two new decoding functions. Intentionally do not use `decode` as the name incase we later want to add a more general `decode` function.
tcharding
force-pushed
the
03-04-decodeing-api
branch
from
e50d71c to
97222f2
Compare
Kixunil
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to release a bare-bones 1.0 version of this crate that excludes the
FromHextrait. So that users can still decode vectors and arrays without the trait introduced two new decoding functions.Intentionally do not use
decodeas the name incase we later want to add a more generaldecodefunction.