WIP: Depend on hex 1.0.0-alpha.0 #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This tests #162. Expect CI to fail because we patch the manifest. |
tcharding
force-pushed
the
02-24-release-0.4
branch
from
d2dd7da to
7714551
Compare
This was referenced Feb 24, 2025
tcharding
force-pushed
the
02-24-release-0.4
branch
from
7714551 to
53ffb6e
Compare
We are attempting to do some release trickery in order to stabalize hex more quickly. It was observed that we only need the `hex` error types in the public API of downstream bitcoin crates that we want to stabalize. So we created a 1.0 that was just the parsing logci and error types. Depend on the new `hex 1.0.0-alpha.0` crate and re-export all its types and traits in the same spot as they were here.
tcharding
force-pushed
the
02-24-release-0.4
branch
from
53ffb6e to
cf9c02b
Compare
|
Ugh, we still can't do this with the make-everything-private version in #162 because we cannot remove How much developer time are we willing to spend chasing this unicorn of the perfect 1.0 crate? EDIT: We could delete the now-private things in 1.0 from 0.4, and if users where using them they have to depend on 0.3 as well - |
|
I believe this is a lost cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are attempting to do some release trickery in order to stabalize hex more quickly. It was observed that we only need the
hexerror types in the public API of downstream bitcoin crates that we want to stabalize. So we created a 1.0 that was just the parsing logci and error types.Depend on the new
hex 1.0.0-alpha.0crate and re-export all its types and traits in the same spot as they were here.