Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docs #160

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Improve the docs #160

merged 6 commits into from
Mar 4, 2025

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Feb 21, 2025

Docs y'all. Done as part of #125.

The example code is definitely meant to be cut'n pasted by users of the
library. Add a CC-0 license so they are explicitly free to do so.
Recently we removed the two wrap examples in favour of a single one but
forgot to update docs mentioning it.
Remove the stale comment and add an additional example call to get hex
string.
Add an `# Errors` section to every public function that returns an
error. Includes a couple of trait methods just for good measure.

Enable the pedantic lint that lints for missing errors sections in
rusdocs.
The `documentation` field of `package` section defaults to docsrs
already, no need to explicitly state it.
As is typical round here we forgot to merge the latest 0.1 release notes
back into master.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 729f739; successfully ran local tests

@tcharding
Copy link
Member Author

Shall we merge this one so it goes in the first alpha release?

@apoelstra apoelstra merged commit 3d928f5 into rust-bitcoin:master Mar 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants