Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-bitcoin #38

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Update rust-bitcoin #38

merged 6 commits into from
Oct 17, 2024

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Oct 16, 2024

As requested, I'm updating this crate to the latest rust-bitcoin version. How do I handle the Cargo-*.lock files in this CI setup? I've just overwritten Cargo-recent.lock with the new Cargo.lock file but unsure what to do with the Cargo-minimal.lock.

@apoelstra @tcharding

@tcharding
Copy link
Member

I usually use a script like this to update the lock files

#!/usr/bin/env bash
#
# Update the minimal/recent lock file

set -euo pipefail

for file in Cargo-minimal.lock Cargo-recent.lock; do
    cp --force "$file" Cargo.lock
    cargo check
    cp --force Cargo.lock "$file"
done

@tcharding
Copy link
Member

Other changes LGTM

@raphjaph
Copy link
Collaborator Author

I usually use a script like this to update the lock files

#!/usr/bin/env bash
#
# Update the minimal/recent lock file

set -euo pipefail

for file in Cargo-minimal.lock Cargo-recent.lock; do
    cp --force "$file" Cargo.lock
    cargo check
    cp --force Cargo.lock "$file"
done

Ok thanks!

@tcharding
Copy link
Member

LGTM!

@raphjaph raphjaph merged commit b7f3b49 into master Oct 17, 2024
14 checks passed
@raphjaph raphjaph deleted the update-rust-bitcoin branch October 17, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants