Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snaps after going back to chrome-headless-shell #288

Merged
merged 5 commits into from
Mar 10, 2025
Merged

update snaps after going back to chrome-headless-shell #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f37d94
feat: Use `chrome-headless-shell` for chromote-based checks
gadenbuie Mar 10, 2025
5074e01
chore: need dev chromote
gadenbuie Mar 10, 2025
db957bc
fix: cat to the file
gadenbuie Mar 10, 2025
a14b149
chore: Use dev chromote in DESCRIPTION
gadenbuie Mar 10, 2025
8732fdb
update snaps after going back to chrome-headless-shell
gadenbuie Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
11 changes: 11 additions & 0 deletions .github/workflows/apps-test-os.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,17 @@ jobs:
run: |
cat("name=gha-", '${{ steps.failed_branch.outputs.name }}', '-', '${{ steps.short.outputs.r-version }}', '-', '${{ runner.os }}', "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)

- name: Use chrome-headless-shell@latest-stable
id: setup_chromote
shell: Rscript {0}
run: |
path <- chromote::chrome_versions_add("latest-stable", binary = "chrome-headless-shell")
cat(
sprintf("\nCHROMOTE_CHROME=%s\n", path),
file = Sys.getenv("GITHUB_ENV"),
append = TRUE
)

# Install packages as necessary!
- name: Run tests
timeout-minutes: 180 # 3 hrs
Expand Down
4 changes: 3 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ URL: https://github.com/rstudio/shinycoreci
BugReports: https://github.com/rstudio/shinycoreci/issues
Imports:
callr,
chromote (>= 0.4.0.9000),
cli,
jsonlite,
progress,
Expand All @@ -24,7 +25,6 @@ Imports:
utils,
withr
Suggests:
chromote (>= 0.4.0),
dplyr,
english,
httpuv,
Expand All @@ -39,6 +39,8 @@ Suggests:
tibble,
tidyr,
waldo
Remotes:
rstudio/chromote
Config/Needs/website: tidyverse/tidytemplate
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand Down
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 400be5eab4631c439e317d1207e428a3]",
"width": 489.9844,
"src": "[image data hash: a3f9a99bb16e34b90d7f87f6a6dc04e6]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 28.08
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/002.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/003.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 2c3fe1858e6d11a0f26a0bc81feb4b24]",
"width": 489.9844,
"src": "[image data hash: 93b7c046dd86eff01a0e01259c6277d1]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 72.8
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/004.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/005.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 73fd8715800f97582828b799397f4f8c]",
"width": 489.9844,
"src": "[image data hash: 8bdcd86c4f0c2e52a0a977933b67752a]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 38.48
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.0/mytest/006.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 400be5eab4631c439e317d1207e428a3]",
"width": 489.9844,
"src": "[image data hash: a3f9a99bb16e34b90d7f87f6a6dc04e6]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 28.08
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/002.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/003.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 2c3fe1858e6d11a0f26a0bc81feb4b24]",
"width": 489.9844,
"src": "[image data hash: 93b7c046dd86eff01a0e01259c6277d1]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 72.8
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/004.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/005.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 73fd8715800f97582828b799397f4f8c]",
"width": 489.9844,
"src": "[image data hash: 8bdcd86c4f0c2e52a0a977933b67752a]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 38.48
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.1/mytest/006.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 400be5eab4631c439e317d1207e428a3]",
"width": 489.9844,
"src": "[image data hash: a3f9a99bb16e34b90d7f87f6a6dc04e6]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 28.08
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/002.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/003.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 2c3fe1858e6d11a0f26a0bc81feb4b24]",
"width": 489.9844,
"src": "[image data hash: 93b7c046dd86eff01a0e01259c6277d1]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 72.8
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/004.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/005.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 73fd8715800f97582828b799397f4f8c]",
"width": 489.9844,
"src": "[image data hash: 8bdcd86c4f0c2e52a0a977933b67752a]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 38.48
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.2/mytest/006.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.3/mytest/001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 400be5eab4631c439e317d1207e428a3]",
"width": 489.9844,
"src": "[image data hash: a3f9a99bb16e34b90d7f87f6a6dc04e6]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 28.08
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.3/mytest/002.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions inst/apps/001-hello/tests/testthat/_snaps/linux-4.3/mytest/003.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
},
"output": {
"distPlot": {
"src": "[image data hash: 2c3fe1858e6d11a0f26a0bc81feb4b24]",
"width": 489.9844,
"src": "[image data hash: 93b7c046dd86eff01a0e01259c6277d1]",
"width": 631.3281,
"height": 400,
"alt": "Plot object",
"coordmap": {
Expand All @@ -18,8 +18,8 @@
"top": 72.8
},
"range": {
"left": 59.1588,
"right": 459.6835,
"left": 59.0707,
"right": 601.0724,
"bottom": 325.56,
"top": 58.04
},
Expand All @@ -33,7 +33,7 @@
}
],
"dims": {
"width": 489.9844,
"width": 631.3281,
"height": 400
}
}
Expand Down
Binary file modified inst/apps/001-hello/tests/testthat/_snaps/linux-4.3/mytest/004.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading