Upgrade PeerTalk project structure for Swift Package Manager #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've got a big, opinionated, but hopefully useful PR, which does the following:
This PR does not make any code changes, except the minimum necessary to play well with Swift Package Manager.
PR #56 got the ball rolling for Swift Package Manager, but it wasn't fully complete. So I continued that work, using the AFNetworking repo as a guide, since it supports Swift Package Manager, CocoaPods, a standard Framework target, and Carthage.
Here's roughly the steps that I took:
peertalk
toSources
Sources/PeerTalk.h
for SPM with double quoted headersFramework/PeerTalk.h
for use in the standard Framework targetsInfo.plist
toFramework
for use by standard targets and so it's not picked up by SPMCLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER
Example
folder and created a separate xcproject and xcworkspace to house thems/Peertalk|peertalk/PeerTalk/g
Phew! It's a lot but I think this project was due for a spring cleaning.
I've tested the following:
But haven't tested CocoaPods or Carthage yet.