Support custom formats for label timestamps #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and I think we don't need Moment Timezone because it's handled by the environment in which Google runs the script, so that simplifies things a bit. |
It is also "freely distributable under the terms of the MIT license" so I don't think we need to add/change anything in our LICENSE file.
lehrblogger
force-pushed
the
sl-timestamp-format
branch
from
3174959 to
3d2cee8
Compare
|
A coworker told me about Google Apps Script Libraries today: https://developers.google.com/apps-script/guide_libraries. I think that's probably overkill for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info in the associated issue #21. I realize we could probably use the library elsewhere as well, but I wanted to minimize the changes for now.
I went back and forth a bit about whether we wanted the minified
moment.jsor not, but since we don't need to optimize for page load times, I figured it better for it to be readable.This is with a format of
"YYYY-MM-DD HH:mm":