feat: fails transfer if free space below thresh #478
+58
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardacoppo
force-pushed
the
stop-transfer-if-free-space-below-threshold
branch
from
ba4ac99 to
2bd3efb
Compare
kapeps
reviewed
Mar 13, 2025
kapeps
reviewed
Mar 13, 2025
| @@ -139,9 +142,10 @@ def process_dataset(child, full:, max_archive_size: DEFAULT_MAX_ARCHIVE_SIZE) | |||
| end | |||
| end | |||
|
|
|||
| def process_dataset_transfer(child, server, root, full:) | |||
| def process_dataset_transfer(child, server, root, full:, thresh:) | |||
There was a problem hiding this comment.
I believe thresh is a bit undescriptive, I would call it min_required_space(and standarize this variable in the cli, instead of having multiple names for it)
Comment on lines
+46
to
+47
| # #param [Integer] min_free_space the minimum required space | ||
| # in the root_dir to perform transfer |
There was a problem hiding this comment.
Is it in bytes? I would use the same unit of space as the other commands i.e. in MB to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/tidewise/story/64361/stop-log-transfer-is-the-free-space-is-some-threshold-on-the-server