Authentication: Registration #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to me this looks fine so far :) thanks a lot |
|
I merged #7 and that resulted in conflicts here. Sorry about that. But I just reverted the formatting change - we can merge this and thereafter apply the ocamlformat. :) |
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
hannesm
reviewed
Jul 3, 2024
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
| let token = generate_uuid () in | ||
| { token_type = "Bearer"; access_token = Uuidm.to_string token; expires_in } | ||
|
|
||
| let create_user ~name ~email ~password = |
There was a problem hiding this comment.
I guess here a validation should take place, so that name and email are valid. this would then also mean that we don't need the clean_string.
having said this, we can do it in a later PR. :)
hannesm
reviewed
Jul 3, 2024
hannesm
reviewed
Jul 3, 2024
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating users
This PR will focus on authentication. Minor changes are included such as CSS styling.
Frontend:
Endpoints:
/sign-up/api/registerBackend: