Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unikernel with new build from builds.robur.coop #105

Merged
merged 36 commits into from
Feb 10, 2025
Merged

Conversation

PizieDust
Copy link
Collaborator

@PizieDust PizieDust commented Jan 29, 2025

This PR is a continuation of the work started in #102 and is related to #54

In this PR, we :

  • download the binary from builds.robur.coop,
  • perform a manifest check to ensure that there's no changes in the bridge or block devices.
  • check that a binary exists from the latest build before attempting to download it
  • check if the vm should be compressed or not
  • modify or update the args passed in the config to albatross
    if everything checks out, then we pass this binary to albatross to perform the update.

@PizieDust PizieDust added the enhancement New feature or request label Jan 29, 2025
@PizieDust PizieDust requested a review from hannesm January 29, 2025 12:55
@PizieDust PizieDust self-assigned this Jan 29, 2025
@PizieDust PizieDust requested a review from reynir January 31, 2025 05:57
Copy link
Contributor

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. I have not tried to review the javascript changes, and I may be missing context.

reynir and others added 2 commits January 31, 2025 16:54
While this is very inefficient it is only temporary until changes to ocaml-solo5-elftool are merged and released.
@PizieDust
Copy link
Collaborator Author

@hannesm Please feel free to merge :)

@hannesm
Copy link
Contributor

hannesm commented Feb 4, 2025

Thanks for your reminder, @PizieDust. I didn't look at this change at all. If you'd like to have this PR reviewed by me, it will need to wait some more time.

OTOH, Reynir reviewed it, so it should be good. I'd appreciate if we avoid a pin in config.ml and wait for the solo5-elftool 0.4 to be released (which, if I understand Reynir, will happen soon)!?

@PizieDust
Copy link
Collaborator Author

Thanks for your reminder, @PizieDust. I didn't look at this change at all. If you'd like to have this PR reviewed by me, it will need to wait some more time.
OTOH, Reynir reviewed it, so it should be good. I'd appreciate if we avoid a pin in config.ml and wait for the solo5-elftool 0.4 to be released (which, if I understand Reynir, will happen soon)!?

Yes we shouldn't merge with the pin. We'll wait for the release.

@reynir
Copy link
Contributor

reynir commented Feb 4, 2025 via email

@reynir
Copy link
Contributor

reynir commented Feb 4, 2025

The code is now updated to ocaml-solo5-elftool.0.4.0 (pending release). With a temporary pin (now removed) it passes CI \o/

@PizieDust
Copy link
Collaborator Author

The code is now updated to ocaml-solo5-elftool.0.4.0 (pending release). With a temporary pin (now removed) it passes CI \o/

Awesome.
Thank you Reynir

@PizieDust PizieDust requested a review from hannesm February 6, 2025 16:00
@hannesm
Copy link
Contributor

hannesm commented Feb 10, 2025

This is fine. I don't quite understand why it triggers the opam-monorepo failure, though.

I'll merge to clean up the queue, and will propose the step for albatross 2.4.0

@hannesm hannesm merged commit 4911828 into main Feb 10, 2025
1 of 2 checks passed
@hannesm hannesm deleted the builds_update_2 branch February 10, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants