-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unikernel with new build from builds.robur.coop #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine. I have not tried to review the javascript changes, and I may be missing context.
… for users to update if needed
I (Reynir) intend to release a new version of solo5-elftool that doesn't depend on owee. In the meantime we pin our owee fork that doesn't depend on Unix.
While this is very inefficient it is only temporary until changes to ocaml-solo5-elftool are merged and released.
@hannesm Please feel free to merge :) |
Thanks for your reminder, @PizieDust. I didn't look at this change at all. If you'd like to have this PR reviewed by me, it will need to wait some more time. OTOH, Reynir reviewed it, so it should be good. I'd appreciate if we avoid a pin in |
Yes we shouldn't merge with the pin. We'll wait for the release. |
This will need more changes for ocaml-solo5-elftool then. I'll work on that
and then merge (I didn't yet look at the new error message code).
tirs. 4. feb. 2025 16.46 skrev Hannes Mehnert ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In albatross.ml
<#105 (comment)>:
> @@ -91,6 +95,98 @@ struct
}
| Error (`Msg err) -> Error err
+ let manifest_devices_match ~bridges ~block_devices binary =
+ let b =
+ Bigarray.Array1.create Bigarray.Int8_unsigned Bigarray.c_layout
+ (String.length binary)
+ in
+ for i = 0 to String.length binary - 1 do
+ b.{i} <- String.get_uint8 binary i
+ done;
+ let binary = b in
can we name the binding b above just binary and then don't need this
alias?
—
Reply to this email directly, view it on GitHub
<#105 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVC324MDX7VDZ6GWX3XBT2ODOETAVCNFSM6AAAAABWCZG5HWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJTGI4DMMJQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
We succesfully tested in CI \o/
The code is now updated to ocaml-solo5-elftool.0.4.0 (pending release). With a temporary pin (now removed) it passes CI \o/ |
Awesome. |
This is fine. I don't quite understand why it triggers the opam-monorepo failure, though. I'll merge to clean up the queue, and will propose the step for albatross 2.4.0 |
This PR is a continuation of the work started in #102 and is related to #54
In this PR, we :
args
passed in the config to albatrossif everything checks out, then we pass this binary to albatross to perform the update.